<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove old Qt database tests"
href="https://bugs.webkit.org/show_bug.cgi?id=160529">bug 160529</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #285287 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove old Qt database tests"
href="https://bugs.webkit.org/show_bug.cgi?id=160529#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Remove old Qt database tests"
href="https://bugs.webkit.org/show_bug.cgi?id=160529">bug 160529</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285287&action=diff" name="attach_285287" title="Patch">attachment 285287</a> <a href="attachment.cgi?id=285287&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285287&action=review">https://bugs.webkit.org/attachment.cgi?id=285287&action=review</a>
This patch does not make sense. Both the description in this bug (<a href="show_bug.cgi?id=160529#c0">comment #0</a>) and the description in the ChangeLog do not explain how the functions testRunner.{closeIdleLocalStorageDatabases, setStorageDatabaseIdleInterval}(), used to test functionality of local storage, are related to "QT" (sic).
<span class="quote">> LayoutTests/ChangeLog:11
> + Removed tests and references to a number of old tests designed
> + to support QT. The two TestRunner functions involved were:
> + testRunner.closeIdleLocalStorageDatabases
> + testRunner.setStorageDatabaseIdleInterval</span >
I think when you write "QT" that you are referring to the Qt WebKit port, but I'm unclear these local storage functions relate to that port. As Alex remarked in test LayoutTests/storage/resources/storage-close-idle-localstorage-databases-immediately.html, the function testRunner.closeIdleLocalStorageDatabases() was added in <<a href="https://trac.webkit.org/changeset/136323">https://trac.webkit.org/changeset/136323</a>> and only implemented for Mac. The function testRunner.setStorageDatabaseIdleInterval() was added in <<a href="https://trac.webkit.org/changeset/122174">https://trac.webkit.org/changeset/122174</a>> and only implemented for Mac.
<span class="quote">>>> LayoutTests/platform/mac-wk2/TestExpectations:-273
>>> -webkit.org/b/147075 http/tests/cache/disk-cache/disk-cache-disable.html [ Pass Failure Timeout ]
>>
>> This seems unrelated.
>
> This is in connection to r42684 which uncovered the failing tests noted here. This test is marked as failing but in fact, passes on everything but GTK</span >
Alex is referring to the fact that the change to this line is unrelated to the purpose of this bug to "remove old [QT] database tests" because the test http/tests/cache/disk-cache/disk-cache-disable.html is a disk cache test. That is, it is not a database test. The WebKit OpenSource Project prefers the approach of one fix per bug/patch. So, we should keep this patch focused on removing the Qt database tests and create a new bug/patch to remove the test http/tests/cache/disk-cache/disk-cache-disable.html.
On another note, I'm unclear how r42684 <<a href="http://trac.webkit.org/changeset/42684">http://trac.webkit.org/changeset/42684</a>>, which is build fix that was made 7 years ago, relates to this test or any of the other tests removed in this patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>