[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156147

--- Comment #65 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 277702
  --> https://bugs.webkit.org/attachment.cgi?id=277702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277702&action=review

>> Source/JavaScriptCore/parser/Keywords.table:11
>> +await           AWAIT
> 
> Are async and await keywords? I think they are contextual keywords, correct?

A number of versions ago, they were treated as contextual keywords (and tokenized as IDENTs) --- but they are checked in so many contexts, that it seems worthwhile to internalize them and tokenize them separately from identifiers --- It may be a close call, but I think when the flag is enabled, it makes more sense to do this.

Contexts where `async` is potentially a keyword include any PrimaryExpression, any AssignmentExpression, and any StatementListItem (including in module code) --- nearly anywhere a BindingIdentifier is expected.

For `await`, it might make a bit more sense to use `matchContextualKeyword`, though, you're right.

Thanks for taking a look at this, I appreciate it Yusuke :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160501/4a45c3f4/attachment.html>