[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156147

--- Comment #64 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 277702
  --> https://bugs.webkit.org/attachment.cgi?id=277702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277702&action=review

super good start! I don't still look through. Quick comments. I'll look into it more.

And I suggest you to measure Octane code-load. That measures the JS parser's performance.

> Source/JavaScriptCore/parser/Keywords.table:11
> +await           AWAIT

Are async and await keywords? I think they are contextual keywords, correct?

> Source/JavaScriptCore/parser/Parser.cpp:357
> +    bool isIdent = matchSpecIdentifier();

Nice catch.

> Source/JavaScriptCore/parser/Parser.cpp:598
> +            if (!(match(IDENT) || match(ASYNC) || match(AWAIT) || match(LET) || match(YIELD)) && !match(OPENBRACE) && !match(OPENBRACKET))

If ASYNC is contextual keyword, we can use matchContextualKeyword function :)

> Source/JavaScriptCore/runtime/RuntimeFlags.h:35
> +    macro(AsyncAwaitEnabled, true)

Nice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160430/9b89a3d3/attachment.html>