[Webkit-unassigned] [Bug 157190] AX: CharacterOffset not working correctly with composed characters and collapsed white spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157190

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 277720
  --> https://bugs.webkit.org/attachment.cgi?id=277720
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277720&action=review

> Source/WebCore/ChangeLog:9
> +        using the helper function in Position to get the real character count for the composed charecter sequence.

charecter -> character

> Source/WebCore/ChangeLog:11
> +        use the actuall space length to create the CharacterOffset in order to generate valid Range object from it.

actuall

> Source/WebCore/accessibility/AXObjectCache.cpp:1557
> +                // When there's collapsed whitespace, text iterator will only count those spaces as one single space.

the text iterator

> Source/WebCore/accessibility/AXObjectCache.cpp:1564
> +                    offsetSoFar += appendLength;

offsetSoFar -> cumulativeOffset

> Source/WebCore/accessibility/AXObjectCache.cpp:1981
> +        Position previousVpDeepPos = previousVisiblePos.deepEquivalent();

Vp looks weird to me

can you call this *visiblePosition*

> Source/WebCore/accessibility/AXObjectCache.cpp:2058
> +    // We don't always move one 'character' a time since there might be composed characters.

at a time

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160429/daec5538/attachment.html>