<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: CharacterOffset not working correctly with composed characters and collapsed white spaces"
href="https://bugs.webkit.org/show_bug.cgi?id=157190#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: CharacterOffset not working correctly with composed characters and collapsed white spaces"
href="https://bugs.webkit.org/show_bug.cgi?id=157190">bug 157190</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277720&action=diff" name="attach_277720" title="Initial patch">attachment 277720</a> <a href="attachment.cgi?id=277720&action=edit" title="Initial patch">[details]</a></span>
Initial patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277720&action=review">https://bugs.webkit.org/attachment.cgi?id=277720&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:9
> + using the helper function in Position to get the real character count for the composed charecter sequence.</span >
charecter -> character
<span class="quote">> Source/WebCore/ChangeLog:11
> + use the actuall space length to create the CharacterOffset in order to generate valid Range object from it.</span >
actuall
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:1557
> + // When there's collapsed whitespace, text iterator will only count those spaces as one single space.</span >
the text iterator
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:1564
> + offsetSoFar += appendLength;</span >
offsetSoFar -> cumulativeOffset
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:1981
> + Position previousVpDeepPos = previousVisiblePos.deepEquivalent();</span >
Vp looks weird to me
can you call this *visiblePosition*
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:2058
> + // We don't always move one 'character' a time since there might be composed characters.</span >
at a time</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>