[Webkit-unassigned] [Bug 156920] Add JSC test results in JSON format to a Buildbot log

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156920

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277713|review?                     |review+
              Flags|                            |

--- Comment #13 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 277713
  --> https://bugs.webkit.org/attachment.cgi?id=277713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277713&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:302
> +    command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s", "--json-output={0}".format(jsonFileName))]

This is OK as-is. We could have passed jsonFileName as an explicit argument instead of interpolating it into the --json-output argument as Getopt::Long, used by run-javascriptcore-tests to parse command line arguments, is smart enough to know that the argument that follow the flag --json-output is the value for the flag.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160429/15359757/attachment-0001.html>