<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Add JSC test results in JSON format to a Buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=156920">bug 156920</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #277713 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Add JSC test results in JSON format to a Buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=156920#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Add JSC test results in JSON format to a Buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=156920">bug 156920</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277713&action=diff" name="attach_277713" title="Patch">attachment 277713</a> <a href="attachment.cgi?id=277713&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277713&action=review">https://bugs.webkit.org/attachment.cgi?id=277713&action=review</a>
r=me
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:302
> + command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s", "--json-output={0}".format(jsonFileName))]</span >
This is OK as-is. We could have passed jsonFileName as an explicit argument instead of interpolating it into the --json-output argument as Getopt::Long, used by run-javascriptcore-tests to parse command line arguments, is smart enough to know that the argument that follow the flag --json-output is the value for the flag.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>