[Webkit-unassigned] [Bug 156920] Add JSC test results in json format to a buildbot log

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156920

--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 277084
  --> https://bugs.webkit.org/attachment.cgi?id=277084
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277084&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:302
> +    command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s", "--json-output=%(_jsonFileName)s")]

This will either break buildbot or will not have the desired effect because WithProperties() only interpolates BuildBot property names and will try to substitute the value of the non-existent BuildBot property _jsonFileName for %(_jsonFileName)s. That is, WithProperties() will not interpolate the value of the local variable _jsonFileName.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:304
> +    logfiles = {"json": _jsonFileName}

As mentioned to Srinivasan in-person today (04/25), I do not see the need to add the JSON output files as a log file that is hyperlinked from a Buildbot build page as a human is unlikely to make use of the JSON result. Moreover, we should explicitly upload the JSON output from the slave to the master (say, as part of the layout test results archive) instead of taking advantage of the implicit uploading of log files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160425/88ef0ace/attachment.html>