<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Add JSC test results in json format to a buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=156920#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Add JSC test results in json format to a buildbot log"
href="https://bugs.webkit.org/show_bug.cgi?id=156920">bug 156920</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277084&action=diff" name="attach_277084" title="Patch">attachment 277084</a> <a href="attachment.cgi?id=277084&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277084&action=review">https://bugs.webkit.org/attachment.cgi?id=277084&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:302
> + command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s", "--json-output=%(_jsonFileName)s")]</span >
This will either break buildbot or will not have the desired effect because WithProperties() only interpolates BuildBot property names and will try to substitute the value of the non-existent BuildBot property _jsonFileName for %(_jsonFileName)s. That is, WithProperties() will not interpolate the value of the local variable _jsonFileName.
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:304
> + logfiles = {"json": _jsonFileName}</span >
As mentioned to Srinivasan in-person today (04/25), I do not see the need to add the JSON output files as a log file that is hyperlinked from a Buildbot build page as a human is unlikely to make use of the JSON result. Moreover, we should explicitly upload the JSON output from the slave to the master (say, as part of the layout test results archive) instead of taking advantage of the implicit uploading of log files.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>