[Webkit-unassigned] [Bug 156949] [Win] Zoom page when Ctrl +/- is pressed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156949

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 277142
  --> https://bugs.webkit.org/attachment.cgi?id=277142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277142&action=review

> Source/WebKit/win/ChangeLog:8
> +        On Windows, the page is not zoomed if the WebView window has focus, and Ctrl +/- is pressed.

Shouldn't the embedding client control zooming? I mean, a non-browser app may embed a WebView and not want to allow zooming of its content.

> Source/WebKit/win/WebView.cpp:2232
> +        return SUCCEEDED(zoomIn(false));

Shouldn't we be passing m_zoomsTextOnly instead of false here to account for whether text-only zooming is enabled?

> Source/WebKit/win/WebView.cpp:2235
> +        return SUCCEEDED(zoomOut(false));

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160423/0ce73808/attachment.html>