<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Zoom page when Ctrl +/- is pressed."
href="https://bugs.webkit.org/show_bug.cgi?id=156949#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Zoom page when Ctrl +/- is pressed."
href="https://bugs.webkit.org/show_bug.cgi?id=156949">bug 156949</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=277142&action=diff" name="attach_277142" title="Patch">attachment 277142</a> <a href="attachment.cgi?id=277142&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=277142&action=review">https://bugs.webkit.org/attachment.cgi?id=277142&action=review</a>
<span class="quote">> Source/WebKit/win/ChangeLog:8
> + On Windows, the page is not zoomed if the WebView window has focus, and Ctrl +/- is pressed.</span >
Shouldn't the embedding client control zooming? I mean, a non-browser app may embed a WebView and not want to allow zooming of its content.
<span class="quote">> Source/WebKit/win/WebView.cpp:2232
> + return SUCCEEDED(zoomIn(false));</span >
Shouldn't we be passing m_zoomsTextOnly instead of false here to account for whether text-only zooming is enabled?
<span class="quote">> Source/WebKit/win/WebView.cpp:2235
> + return SUCCEEDED(zoomOut(false));</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>