[Webkit-unassigned] [Bug 156939] Autogenerated IDBFactory.open() does the wrong thing if you pass an explicit 'undefined' as the second argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156939

--- Comment #18 from Chris Dumez <cdumez at apple.com> ---
(In reply to comment #9)
> Comment on attachment 277135 [details]
> WIP patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277135&action=review
> 
> Thanks for tackling this!
> 
> Giving a review feedback comment to clarify where I thought this was heading:
> 
> > Source/WebCore/Modules/indexeddb/IDBFactory.h:57
> >      RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name, ExceptionCodeWithMessage&);
> > -    RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name, unsigned long long version, ExceptionCodeWithMessage&);
> > +    RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name, Optional<unsigned long long> version, ExceptionCodeWithMessage&);
> 
> The new method signature:
> + RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name,
> Optional<unsigned long long> version, ExceptionCodeWithMessage&);
> Seems great.
> 
> But my understanding was that the new mechanism would completely obsolete
> the version of open() without the version argument.
> 
> i.e., line 56 should be gone, and everything in the auto generated
> JSIDBFactoryOpenFunction would call the new line 57 version.

Yes, I haven't had time to experiment with this part yet but I will.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160423/098fa8d3/attachment-0001.html>