<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Autogenerated IDBFactory.open() does the wrong thing if you pass an explicit 'undefined' as the second argument"
href="https://bugs.webkit.org/show_bug.cgi?id=156939#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Autogenerated IDBFactory.open() does the wrong thing if you pass an explicit 'undefined' as the second argument"
href="https://bugs.webkit.org/show_bug.cgi?id=156939">bug 156939</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156939#c9">comment #9</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=277135&action=diff" name="attach_277135" title="WIP patch">attachment 277135</a> <a href="attachment.cgi?id=277135&action=edit" title="WIP patch">[details]</a></span>
> WIP patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=277135&action=review">https://bugs.webkit.org/attachment.cgi?id=277135&action=review</a>
>
> Thanks for tackling this!
>
> Giving a review feedback comment to clarify where I thought this was heading:
>
> > Source/WebCore/Modules/indexeddb/IDBFactory.h:57
> > RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name, ExceptionCodeWithMessage&);
> > - RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name, unsigned long long version, ExceptionCodeWithMessage&);
> > + RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name, Optional<unsigned long long> version, ExceptionCodeWithMessage&);
>
> The new method signature:
> + RefPtr<IDBOpenDBRequest> open(ScriptExecutionContext&, const String& name,
> Optional<unsigned long long> version, ExceptionCodeWithMessage&);
> Seems great.
>
> But my understanding was that the new mechanism would completely obsolete
> the version of open() without the version argument.
>
> i.e., line 56 should be gone, and everything in the auto generated
> JSIDBFactoryOpenFunction would call the new line 57 version.</span >
Yes, I haven't had time to experiment with this part yet but I will.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>