[Webkit-unassigned] [Bug 151113] calling super() a second time in a constructor should throw
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 19 19:08:29 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=151113
--- Comment #49 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 276749
--> https://bugs.webkit.org/attachment.cgi?id=276749
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=276749&action=review
>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1103
>> + constantWasSet = true;
>
> Doesn't setConstant already assign to this variable for us?
I did as do in another 'case's. Anyway constantWasSet is local variable declared just above of the switch/case construction, but In setConstant we assign m_foundConstants of m_state object.
>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4440
>> + m_jit.comparePtr(JITCompiler::Equal, value.gpr(), TrustedImm32(JSValue::encode(JSValue())), result.gpr());
>
> This should be TrustedImm64
There is no function for TrustedImm64 in MacroAssembler.h, only for TrustedImm32. Do I need create new one?
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/assembler/MacroAssembler.h#L998
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160420/049d852d/attachment.html>
More information about the webkit-unassigned
mailing list