[Webkit-unassigned] [Bug 151113] calling super() a second time in a constructor should throw

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 19 18:30:23 PDT 2016


Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
 Attachment #276749|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #48 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 276749
  --> https://bugs.webkit.org/attachment.cgi?id=276749

View in context: https://bugs.webkit.org/attachment.cgi?id=276749&action=review

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1103
> +                constantWasSet = true;

Doesn't setConstant already assign to this variable for us?

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4440
> +        m_jit.comparePtr(JITCompiler::Equal, value.gpr(), TrustedImm32(JSValue::encode(JSValue())), result.gpr());

This should be TrustedImm64

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160420/d03d0b6b/attachment.html>

More information about the webkit-unassigned mailing list