[Webkit-unassigned] [Bug 156713] [Win][IndexedDB] Fix build errors.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156713

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276667|review?                     |review-
              Flags|                            |

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 276667
  --> https://bugs.webkit.org/attachment.cgi?id=276667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276667&action=review

cool!

> Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:44
> -    return std::make_unique<MemoryBackingStoreTransaction>(backingStore, info);
> +    return std::unique_ptr<MemoryBackingStoreTransaction>(new MemoryBackingStoreTransaction(backingStore, info));

This shouldn't be needed.

> Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:48
> -    return std::make_unique<MemoryIDBBackingStore>(identifier);
> +    return std::unique_ptr<MemoryIDBBackingStore>(new MemoryIDBBackingStore(identifier));

This shouldn't be needed.

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1188
> -    auto callback = [this, self, refTransaction](const IDBError& error) {
> +    ErrorCallback callback = [this, self, refTransaction](const IDBError& error) {

This shouldn't be needed.

> Source/WebKit/win/storage/WebDatabaseProvider.cpp:45
> +    sprintf_s(databaseDirectory, MAX_PATH, "%s\\%s", appDataDirectory, executableName);

On Mac we use .../WebKit/Databases/___IndexedDB.  We should probably do something similar here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160418/50bfee71/attachment-0001.html>