<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win][IndexedDB] Fix build errors."
href="https://bugs.webkit.org/show_bug.cgi?id=156713">bug 156713</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #276667 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win][IndexedDB] Fix build errors."
href="https://bugs.webkit.org/show_bug.cgi?id=156713#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win][IndexedDB] Fix build errors."
href="https://bugs.webkit.org/show_bug.cgi?id=156713">bug 156713</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276667&action=diff" name="attach_276667" title="Patch">attachment 276667</a> <a href="attachment.cgi?id=276667&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276667&action=review">https://bugs.webkit.org/attachment.cgi?id=276667&action=review</a>
cool!
<span class="quote">> Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:44
> - return std::make_unique<MemoryBackingStoreTransaction>(backingStore, info);
> + return std::unique_ptr<MemoryBackingStoreTransaction>(new MemoryBackingStoreTransaction(backingStore, info));</span >
This shouldn't be needed.
<span class="quote">> Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:48
> - return std::make_unique<MemoryIDBBackingStore>(identifier);
> + return std::unique_ptr<MemoryIDBBackingStore>(new MemoryIDBBackingStore(identifier));</span >
This shouldn't be needed.
<span class="quote">> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:1188
> - auto callback = [this, self, refTransaction](const IDBError& error) {
> + ErrorCallback callback = [this, self, refTransaction](const IDBError& error) {</span >
This shouldn't be needed.
<span class="quote">> Source/WebKit/win/storage/WebDatabaseProvider.cpp:45
> + sprintf_s(databaseDirectory, MAX_PATH, "%s\\%s", appDataDirectory, executableName);</span >
On Mac we use .../WebKit/Databases/___IndexedDB. We should probably do something similar here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>