[Webkit-unassigned] [Bug 156672] Element should be const in StyleResolver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156672

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276588|review?                     |review+
              Flags|                            |

--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 276588
  --> https://bugs.webkit.org/attachment.cgi?id=276588
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276588&action=review

I assume the idea here is to use const to sort of mean "DOM mutation forbidden".

> Source/WebCore/ChangeLog:10
> +        This patch just does Element* -> const Element*, all the groundwork has beend done already.

Typo: beend

> Source/WebCore/css/StyleResolver.cpp:761
> +void StyleResolver::adjustRenderStyle(RenderStyle& style, const RenderStyle& parentStyle, const Element *element)

Space should be after the *, not before it.

> Source/WebCore/rendering/RenderThemeIOS.mm:628
>      else if (element->hasTagName(HTMLNames::inputTag))
> -        adjustInputElementButtonStyle(style, static_cast<HTMLInputElement&>(*element));
> +        adjustInputElementButtonStyle(style, downcast<HTMLInputElement>(*element));

Should also use is<HTMLInputElement> instead of hasTagName(HTMLNames::inputTag).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160417/7a65ef8f/attachment.html>