<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Element should be const in StyleResolver"
href="https://bugs.webkit.org/show_bug.cgi?id=156672">bug 156672</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #276588 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Element should be const in StyleResolver"
href="https://bugs.webkit.org/show_bug.cgi?id=156672#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Element should be const in StyleResolver"
href="https://bugs.webkit.org/show_bug.cgi?id=156672">bug 156672</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276588&action=diff" name="attach_276588" title="patch">attachment 276588</a> <a href="attachment.cgi?id=276588&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276588&action=review">https://bugs.webkit.org/attachment.cgi?id=276588&action=review</a>
I assume the idea here is to use const to sort of mean "DOM mutation forbidden".
<span class="quote">> Source/WebCore/ChangeLog:10
> + This patch just does Element* -> const Element*, all the groundwork has beend done already.</span >
Typo: beend
<span class="quote">> Source/WebCore/css/StyleResolver.cpp:761
> +void StyleResolver::adjustRenderStyle(RenderStyle& style, const RenderStyle& parentStyle, const Element *element)</span >
Space should be after the *, not before it.
<span class="quote">> Source/WebCore/rendering/RenderThemeIOS.mm:628
> else if (element->hasTagName(HTMLNames::inputTag))
> - adjustInputElementButtonStyle(style, static_cast<HTMLInputElement&>(*element));
> + adjustInputElementButtonStyle(style, downcast<HTMLInputElement>(*element));</span >
Should also use is<HTMLInputElement> instead of hasTagName(HTMLNames::inputTag).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>