[Webkit-unassigned] [Bug 118234] [GTK] Menu list button doesn't use the text color from the theme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118234

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276473|review?                     |review+
              Flags|                            |

--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 276473
  --> https://bugs.webkit.org/attachment.cgi?id=276473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276473&action=review

> Source/WebCore/rendering/RenderThemeGtk.cpp:776
> +#if GTK_CHECK_VERSION(3, 20, 0)

Seems slightly nicer to put the #if inside the function since there is no difference in the arguments type or usage.

> Source/WebCore/rendering/RenderThemeGtk.cpp:779
> +    RenderThemeGadget::Info info = { RenderThemeGadget::Type::Generic, "combobox", element->isDisabledFormControl() ? GTK_STATE_FLAG_INSENSITIVE : GTK_STATE_FLAG_NORMAL, { } };

I believe there is no need for the "=" here.

> Source/WebCore/rendering/RenderThemeGtk.cpp:781
> +    Vector<RenderThemeGadget::Info> children = {

I believe there is no need for the "=" here.

> Source/WebCore/rendering/RenderThemeGtk.cpp:786
> +    return std::make_unique<RenderThemeBoxGadget>(info, children, comboGadget.get())->child(0)->color();

Why does this need to be constructed on the heap with make_unique instead of just constructing it on the stack?

    return RenderThemeBoxGadget(info, children, comboGadget.get()).child(0)->color();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160415/5dbc93bf/attachment.html>