<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Menu list button doesn't use the text color from the theme"
href="https://bugs.webkit.org/show_bug.cgi?id=118234">bug 118234</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #276473 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Menu list button doesn't use the text color from the theme"
href="https://bugs.webkit.org/show_bug.cgi?id=118234#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Menu list button doesn't use the text color from the theme"
href="https://bugs.webkit.org/show_bug.cgi?id=118234">bug 118234</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276473&action=diff" name="attach_276473" title="Patch">attachment 276473</a> <a href="attachment.cgi?id=276473&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276473&action=review">https://bugs.webkit.org/attachment.cgi?id=276473&action=review</a>
<span class="quote">> Source/WebCore/rendering/RenderThemeGtk.cpp:776
> +#if GTK_CHECK_VERSION(3, 20, 0)</span >
Seems slightly nicer to put the #if inside the function since there is no difference in the arguments type or usage.
<span class="quote">> Source/WebCore/rendering/RenderThemeGtk.cpp:779
> + RenderThemeGadget::Info info = { RenderThemeGadget::Type::Generic, "combobox", element->isDisabledFormControl() ? GTK_STATE_FLAG_INSENSITIVE : GTK_STATE_FLAG_NORMAL, { } };</span >
I believe there is no need for the "=" here.
<span class="quote">> Source/WebCore/rendering/RenderThemeGtk.cpp:781
> + Vector<RenderThemeGadget::Info> children = {</span >
I believe there is no need for the "=" here.
<span class="quote">> Source/WebCore/rendering/RenderThemeGtk.cpp:786
> + return std::make_unique<RenderThemeBoxGadget>(info, children, comboGadget.get())->child(0)->color();</span >
Why does this need to be constructed on the heap with make_unique instead of just constructing it on the stack?
return RenderThemeBoxGadget(info, children, comboGadget.get()).child(0)->color();</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>