[Webkit-unassigned] [Bug 156540] WebKit2 should allow clients to use different plug-in load policies for private browsing.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 10:57:44 PDT 2016


--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 276333
  --> https://bugs.webkit.org/attachment.cgi?id=276333
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=276333&action=review

> Source/WebKit2/UIProcess/WebProcessPool.cpp:1320
> +void WebProcessPool::setPluginLoadClientPolicyForBrowsingMode(bool forPrivateBrowsing, WebCore::PluginLoadClientPolicy policy, const String& host, const String& bundleIdentifier, const String& versionString)

Instead of a boolean here, use an enum class. Something like.

enum class ForPrivateBrowsing {

> Source/WebKit2/WebProcess/WebProcess.h:373
> +    void setPluginLoadClientPolicyFromCreationParameters(HashMap<String, HashMap<String, HashMap<String, uint8_t>>> *, bool);

This hash map should be a const reference. Also, I think you can just call it setPluginLoadClientPolicies.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160413/c55a8119/attachment.html>

More information about the webkit-unassigned mailing list