<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2 should allow clients to use different plug-in load policies for private browsing."
href="https://bugs.webkit.org/show_bug.cgi?id=156540#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebKit2 should allow clients to use different plug-in load policies for private browsing."
href="https://bugs.webkit.org/show_bug.cgi?id=156540">bug 156540</a>
from <span class="vcard"><a class="email" href="mailto:andersca@apple.com" title="Anders Carlsson <andersca@apple.com>"> <span class="fn">Anders Carlsson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276333&action=diff" name="attach_276333" title="Patch 1">attachment 276333</a> <a href="attachment.cgi?id=276333&action=edit" title="Patch 1">[details]</a></span>
Patch 1
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276333&action=review">https://bugs.webkit.org/attachment.cgi?id=276333&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/WebProcessPool.cpp:1320
> +void WebProcessPool::setPluginLoadClientPolicyForBrowsingMode(bool forPrivateBrowsing, WebCore::PluginLoadClientPolicy policy, const String& host, const String& bundleIdentifier, const String& versionString)</span >
Instead of a boolean here, use an enum class. Something like.
enum class ForPrivateBrowsing {
No,
Yes
};
<span class="quote">> Source/WebKit2/WebProcess/WebProcess.h:373
> + void setPluginLoadClientPolicyFromCreationParameters(HashMap<String, HashMap<String, HashMap<String, uint8_t>>> *, bool);</span >
This hash map should be a const reference. Also, I think you can just call it setPluginLoadClientPolicies.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>