[Webkit-unassigned] [Bug 156512] Crash at com.apple.JavaScriptCore: bool WTF::startsWith<WTF::StringImpl, WTF::StringImpl> + 8

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 08:21:00 PDT 2016


--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 276270
  --> https://bugs.webkit.org/attachment.cgi?id=276270

View in context: https://bugs.webkit.org/attachment.cgi?id=276270&action=review

>> Source/WebCore/cssjit/SelectorCompiler.cpp:2823
>> +        return false;
> Looks like this should be merged with the "AtomicStringImpl& valueImpl = *attribute->value().impl();" below.

Checking for the null string would be more efficient than checking for the empty string for the non-null, non-empty case. So unless we want to optimize the empty string case, I suggest using isNull or checking if impl() is nullptr instead.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160413/c43398a4/attachment-0001.html>

More information about the webkit-unassigned mailing list