<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED DUPLICATE - Crash at com.apple.JavaScriptCore: bool WTF::startsWith<WTF::StringImpl, WTF::StringImpl> + 8"
href="https://bugs.webkit.org/show_bug.cgi?id=156512#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED DUPLICATE - Crash at com.apple.JavaScriptCore: bool WTF::startsWith<WTF::StringImpl, WTF::StringImpl> + 8"
href="https://bugs.webkit.org/show_bug.cgi?id=156512">bug 156512</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276270&action=diff" name="attach_276270" title="patch">attachment 276270</a> <a href="attachment.cgi?id=276270&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276270&action=review">https://bugs.webkit.org/attachment.cgi?id=276270&action=review</a>
<span class="quote">>> Source/WebCore/cssjit/SelectorCompiler.cpp:2823
>> + return false;
>
> Looks like this should be merged with the "AtomicStringImpl& valueImpl = *attribute->value().impl();" below.</span >
Checking for the null string would be more efficient than checking for the empty string for the non-null, non-empty case. So unless we want to optimize the empty string case, I suggest using isNull or checking if impl() is nullptr instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>