[Webkit-unassigned] [Bug 111193] Web Inspector: Keyboard shortcut for "Inspect Element" only works when Web Inspector is open.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111193

--- Comment #13 from Brian Burg <bburg at apple.com> ---
Comment on attachment 276215
  --> https://bugs.webkit.org/attachment.cgi?id=276215
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=276215&action=review

> Source/WebKit2/UIProcess/API/C/WKInspector.cpp:130
> +    toImpl(inspectorRef)->togglePointToInspect();

I would prefer a simple isPointToInspectEnabled / setPointToInspectEnabled pair rather than having toggle. That way a client doesn't have to double-check every time if they want to unconditionally enable it.

> Source/WebKit2/WebProcess/WebPage/WebInspectorUI.messages.in:39
> +    EnablePointToInspect()

Can this just be one message, SetPointToInspectEnabled?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160412/d514cb2a/attachment.html>