<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Web Inspector: Keyboard shortcut for "Inspect Element" only works when Web Inspector is open."
href="https://bugs.webkit.org/show_bug.cgi?id=111193#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Web Inspector: Keyboard shortcut for "Inspect Element" only works when Web Inspector is open."
href="https://bugs.webkit.org/show_bug.cgi?id=111193">bug 111193</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276215&action=diff" name="attach_276215" title="[PATCH] Proposed Fix">attachment 276215</a> <a href="attachment.cgi?id=276215&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276215&action=review">https://bugs.webkit.org/attachment.cgi?id=276215&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/C/WKInspector.cpp:130
> + toImpl(inspectorRef)->togglePointToInspect();</span >
I would prefer a simple isPointToInspectEnabled / setPointToInspectEnabled pair rather than having toggle. That way a client doesn't have to double-check every time if they want to unconditionally enable it.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebInspectorUI.messages.in:39
> + EnablePointToInspect()</span >
Can this just be one message, SetPointToInspectEnabled?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>