[Webkit-unassigned] [Bug 156460] [CMake] Make FOLDER property INHERITED

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 10 23:00:10 PDT 2016


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #276120|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 276120
  --> https://bugs.webkit.org/attachment.cgi?id=276120

View in context: https://bugs.webkit.org/attachment.cgi?id=276120&action=review

Thank you for this fix! I found a couple of minor errors in the ChangeLog. If you fix them, we can land the change.

> ChangeLog:8
> +        Some CMake targets are not set the FOLDER property and

Some CMake targets are not setting the FOLDER property. This causes the

> ChangeLog:9
> +        generated projects are in the top folder in the solution.

generated projects to be displayed in the top-level folder of the solution.

> ChangeLog:11
> +        Making FOLDER property INHERITED is the easy way to set the

Making the FOLDER property INHERITED ensures that all the targets

> ChangeLog:12
> +        proeprty to all targets under a directory.

are placed in their proper directories.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160411/09b2a866/attachment.html>

More information about the webkit-unassigned mailing list