<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Make FOLDER property INHERITED"
href="https://bugs.webkit.org/show_bug.cgi?id=156460">bug 156460</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #276120 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Make FOLDER property INHERITED"
href="https://bugs.webkit.org/show_bug.cgi?id=156460#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Make FOLDER property INHERITED"
href="https://bugs.webkit.org/show_bug.cgi?id=156460">bug 156460</a>
from <span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=276120&action=diff" name="attach_276120" title="Patch">attachment 276120</a> <a href="attachment.cgi?id=276120&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=276120&action=review">https://bugs.webkit.org/attachment.cgi?id=276120&action=review</a>
Thank you for this fix! I found a couple of minor errors in the ChangeLog. If you fix them, we can land the change.
<span class="quote">> ChangeLog:8
> + Some CMake targets are not set the FOLDER property and</span >
Some CMake targets are not setting the FOLDER property. This causes the
<span class="quote">> ChangeLog:9
> + generated projects are in the top folder in the solution.</span >
generated projects to be displayed in the top-level folder of the solution.
<span class="quote">> ChangeLog:11
> + Making FOLDER property INHERITED is the easy way to set the</span >
Making the FOLDER property INHERITED ensures that all the targets
<span class="quote">> ChangeLog:12
> + proeprty to all targets under a directory.</span >
are placed in their proper directories.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>