[Webkit-unassigned] [Bug 156400] Touching any IDL files rebuilds all bindings in CMake Ninja build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156400

--- Comment #6 from Fujii Hironori <Hironori.Fujii at jp.sony.com> ---
Thank you for reviewing my patch.

(In reply to comment #2)
> but It's not obvious to me why this stops us
> from rebuilding all bindings.

1) supplemental_dependency.tmp depens on all IDL
2) All bindgs depnds on supplemental_dependency.tmp

In Source/WebCore/CMakeLists.txt:

> add_custom_command(
>     OUTPUT ${SUPPLEMENTAL_DEPENDENCY_FILE} ${WINDOW_CONSTRUCTORS_FILE} ${WORKERGLOBALSCOPE_CONSTRUCTORS_FILE} ${DEDICATEDWORKERGLOBALSCOPE_CONSTRUCTORS_FILE}
>     DEPENDS ${WEBCORE_DIR}/bindings/scripts/preprocess-idls.pl ${SCRIPTS_PREPROCESS_IDLS} ${WebCore_IDL_FILES} ${ObjC_Bindings_IDL_FILES} ${WebCoreTestSupport_IDL_FILES} ${WEBCORE_DIR}/CMakeLists.txt
>     COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/bindings/scripts/preprocess-idls.pl --defines "${FEATURE_DEFINES_JAVASCRIPT}" --idlFilesList ${IDL_FILES_TMP} --supplementalDependencyFile ${SUPPLEMENTAL_DEPENDENCY_FILE} --windowConstructorsFile ${WINDOW_CONSTRUCTORS_FILE} --workerGlobalScopeConstructorsFile ${WORKERGLOBALSCOPE_CONSTRUCTORS_FILE}
> --dedicatedWorkerGlobalScopeConstructorsFile ${DEDICATEDWORKERGLOBALSCOPE_CONSTRUCTORS_FILE}
>     VERBATIM)

> GENERATE_BINDINGS(WebCore_DERIVED_SOURCES
>     "${WebCore_IDL_FILES}"
>     "${WEBCORE_DIR}"
>     "${IDL_INCLUDES}"
>     "${FEATURE_DEFINES_JAVASCRIPT}"
>     ${DERIVED_SOURCES_WEBCORE_DIR} JS JS cpp
>     ${IDL_ATTRIBUTES_FILE}
>     ${SUPPLEMENTAL_DEPENDENCY_FILE}
>     ${ADDITIONAL_BINDINGS_DEPENDENCIES})

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160411/88010a88/attachment.html>