<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Touching any IDL files rebuilds all bindings in CMake Ninja build"
href="https://bugs.webkit.org/show_bug.cgi?id=156400#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Touching any IDL files rebuilds all bindings in CMake Ninja build"
href="https://bugs.webkit.org/show_bug.cgi?id=156400">bug 156400</a>
from <span class="vcard"><a class="email" href="mailto:Hironori.Fujii@jp.sony.com" title="Fujii Hironori <Hironori.Fujii@jp.sony.com>"> <span class="fn">Fujii Hironori</span></a>
</span></b>
<pre>Thank you for reviewing my patch.
(In reply to <a href="show_bug.cgi?id=156400#c2">comment #2</a>)
<span class="quote">> but It's not obvious to me why this stops us
> from rebuilding all bindings.</span >
1) supplemental_dependency.tmp depens on all IDL
2) All bindgs depnds on supplemental_dependency.tmp
In Source/WebCore/CMakeLists.txt:
<span class="quote">> add_custom_command(
> OUTPUT ${SUPPLEMENTAL_DEPENDENCY_FILE} ${WINDOW_CONSTRUCTORS_FILE} ${WORKERGLOBALSCOPE_CONSTRUCTORS_FILE} ${DEDICATEDWORKERGLOBALSCOPE_CONSTRUCTORS_FILE}
> DEPENDS ${WEBCORE_DIR}/bindings/scripts/preprocess-idls.pl ${SCRIPTS_PREPROCESS_IDLS} ${WebCore_IDL_FILES} ${ObjC_Bindings_IDL_FILES} ${WebCoreTestSupport_IDL_FILES} ${WEBCORE_DIR}/CMakeLists.txt
> COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/bindings/scripts/preprocess-idls.pl --defines "${FEATURE_DEFINES_JAVASCRIPT}" --idlFilesList ${IDL_FILES_TMP} --supplementalDependencyFile ${SUPPLEMENTAL_DEPENDENCY_FILE} --windowConstructorsFile ${WINDOW_CONSTRUCTORS_FILE} --workerGlobalScopeConstructorsFile ${WORKERGLOBALSCOPE_CONSTRUCTORS_FILE}
> --dedicatedWorkerGlobalScopeConstructorsFile ${DEDICATEDWORKERGLOBALSCOPE_CONSTRUCTORS_FILE}
> VERBATIM)</span >
<span class="quote">> GENERATE_BINDINGS(WebCore_DERIVED_SOURCES
> "${WebCore_IDL_FILES}"
> "${WEBCORE_DIR}"
> "${IDL_INCLUDES}"
> "${FEATURE_DEFINES_JAVASCRIPT}"
> ${DERIVED_SOURCES_WEBCORE_DIR} JS JS cpp
> ${IDL_ATTRIBUTES_FILE}
> ${SUPPLEMENTAL_DEPENDENCY_FILE}
> ${ADDITIONAL_BINDINGS_DEPENDENCIES})</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>