[Webkit-unassigned] [Bug 156358] WebPlaybackControlsManager should support mediaSelectionOptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156358

Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275926|review?                     |review+
              Flags|                            |

--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 275926
  --> https://bugs.webkit.org/attachment.cgi?id=275926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275926&action=review

r=me, with possible nits.

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:269
> +        [webOption setLocalizedDisplayName:name];

I could be wrong, but I feel like the new preferred style guides for this kind of thing would read:

webOption.get().localizedDisplayName = name;

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:280
> +    [controlsManager setAudioMediaSelectionOptions:webOptions.get()];

...and:

controlsManager.get().audioMediaSelectionOptions = webOptions.get();

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:282
> +        [controlsManager setCurrentAudioMediaSelectionOption:[webOptions objectAtIndex:static_cast<NSUInteger>(selectedIndex)]];

...and:

controlsManager.get().currentAudioMediaSelectionOption = [webOptions objectAtIndex:static_cast<NSUInteger>(selectedIndex)]];

etc.

But I may not be correct about that use of style.  Aside from than that, good patch!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160407/6e07a841/attachment.html>