<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jer.noble@apple.com" title="Jer Noble <jer.noble@apple.com>"> <span class="fn">Jer Noble</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WebPlaybackControlsManager should support mediaSelectionOptions"
href="https://bugs.webkit.org/show_bug.cgi?id=156358">bug 156358</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #275926 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebPlaybackControlsManager should support mediaSelectionOptions"
href="https://bugs.webkit.org/show_bug.cgi?id=156358#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebPlaybackControlsManager should support mediaSelectionOptions"
href="https://bugs.webkit.org/show_bug.cgi?id=156358">bug 156358</a>
from <span class="vcard"><a class="email" href="mailto:jer.noble@apple.com" title="Jer Noble <jer.noble@apple.com>"> <span class="fn">Jer Noble</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275926&action=diff" name="attach_275926" title="Patch">attachment 275926</a> <a href="attachment.cgi?id=275926&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275926&action=review">https://bugs.webkit.org/attachment.cgi?id=275926&action=review</a>
r=me, with possible nits.
<span class="quote">> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:269
> + [webOption setLocalizedDisplayName:name];</span >
I could be wrong, but I feel like the new preferred style guides for this kind of thing would read:
webOption.get().localizedDisplayName = name;
<span class="quote">> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:280
> + [controlsManager setAudioMediaSelectionOptions:webOptions.get()];</span >
...and:
controlsManager.get().audioMediaSelectionOptions = webOptions.get();
<span class="quote">> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:282
> + [controlsManager setCurrentAudioMediaSelectionOption:[webOptions objectAtIndex:static_cast<NSUInteger>(selectedIndex)]];</span >
...and:
controlsManager.get().currentAudioMediaSelectionOption = [webOptions objectAtIndex:static_cast<NSUInteger>(selectedIndex)]];
etc.
But I may not be correct about that use of style. Aside from than that, good patch!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>