[Webkit-unassigned] [Bug 156334] Initial Link preload support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 12:30:01 PDT 2016


Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
 Attachment #275888|review?                     |review-
              Flags|                            |

--- Comment #19 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 275888
  --> https://bugs.webkit.org/attachment.cgi?id=275888

View in context: https://bugs.webkit.org/attachment.cgi?id=275888&action=review

> Source/WebCore/loader/LinkLoader.cpp:88
> +bool LinkLoader::getResourceTypeFromAsAttribute(const String& as, CachedResource::Type& type)

Should probably return an Optional<CachedResource::Type> and return NullOpt for the error case.

> Source/WebCore/loader/LinkLoader.cpp:138
> +    document.cachedResourceLoader().preload(type, linkRequest, "");

"" -> emptyString()

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160407/64558e27/attachment-0001.html>

More information about the webkit-unassigned mailing list