<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Initial Link preload support"
href="https://bugs.webkit.org/show_bug.cgi?id=156334">bug 156334</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #275888 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Initial Link preload support"
href="https://bugs.webkit.org/show_bug.cgi?id=156334#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Initial Link preload support"
href="https://bugs.webkit.org/show_bug.cgi?id=156334">bug 156334</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275888&action=diff" name="attach_275888" title="Patch">attachment 275888</a> <a href="attachment.cgi?id=275888&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275888&action=review">https://bugs.webkit.org/attachment.cgi?id=275888&action=review</a>
<span class="quote">> Source/WebCore/loader/LinkLoader.cpp:88
> +bool LinkLoader::getResourceTypeFromAsAttribute(const String& as, CachedResource::Type& type)</span >
Should probably return an Optional<CachedResource::Type> and return NullOpt for the error case.
<span class="quote">> Source/WebCore/loader/LinkLoader.cpp:138
> + document.cachedResourceLoader().preload(type, linkRequest, "");</span >
"" -> emptyString()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>