[Webkit-unassigned] [Bug 149439] Shadow DOM: Implement display: contents for slots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149439

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275782|review?                     |review+
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 275782
  --> https://bugs.webkit.org/attachment.cgi?id=275782
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275782&action=review

> Source/WebCore/dom/ElementRareData.h:132
> +    unsigned m_hasDisplayContents : 1;

It's unfortunate that we have to use rare data for this.
It's interesting that we have bit flags about m_childrenAffectedByHover and m_childrenAffectedByLastChildRules
when there are three node flags of a similar stuff:
        ChildrenAffectedByFirstChildRulesFlag = 1 << 25,
        ChildrenAffectedByLastChildRulesFlag = 1 << 26,
        ChildrenAffectedByHoverRulesFlag = 1 << 27,
perhaps we need to re-think about these bit flags...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160406/ccec13f1/attachment.html>