<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Shadow DOM: Implement display: contents for slots"
href="https://bugs.webkit.org/show_bug.cgi?id=149439">bug 149439</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #275782 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Shadow DOM: Implement display: contents for slots"
href="https://bugs.webkit.org/show_bug.cgi?id=149439#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Shadow DOM: Implement display: contents for slots"
href="https://bugs.webkit.org/show_bug.cgi?id=149439">bug 149439</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275782&action=diff" name="attach_275782" title="patch">attachment 275782</a> <a href="attachment.cgi?id=275782&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275782&action=review">https://bugs.webkit.org/attachment.cgi?id=275782&action=review</a>
<span class="quote">> Source/WebCore/dom/ElementRareData.h:132
> + unsigned m_hasDisplayContents : 1;</span >
It's unfortunate that we have to use rare data for this.
It's interesting that we have bit flags about m_childrenAffectedByHover and m_childrenAffectedByLastChildRules
when there are three node flags of a similar stuff:
ChildrenAffectedByFirstChildRulesFlag = 1 << 25,
ChildrenAffectedByLastChildRulesFlag = 1 << 26,
ChildrenAffectedByHoverRulesFlag = 1 << 27,
perhaps we need to re-think about these bit flags...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>