[Webkit-unassigned] [Bug 156260] MIPS: support Signed cond in branchTest32()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156260

--- Comment #4 from Julien Brianceau <jbriance at cisco.com> ---
Comment on attachment 275716
  --> https://bugs.webkit.org/attachment.cgi?id=275716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275716&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1505
> +        if ((cond != Signed) && m_fixedWidth)
> +            m_assembler.nop();

To me, these 2 lines are not needed.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1515
> +            ASSERT_NOT_REACHED();

Very good idea to add this, but please use "RELEASE_ASSERT_NOT_REACHED" instead.

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1532
> +                ASSERT_NOT_REACHED();

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160406/bd7d9463/attachment.html>