<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MIPS: support Signed cond in branchTest32()"
href="https://bugs.webkit.org/show_bug.cgi?id=156260#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MIPS: support Signed cond in branchTest32()"
href="https://bugs.webkit.org/show_bug.cgi?id=156260">bug 156260</a>
from <span class="vcard"><a class="email" href="mailto:jbriance@cisco.com" title="Julien Brianceau <jbriance@cisco.com>"> <span class="fn">Julien Brianceau</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275716&action=diff" name="attach_275716" title="Patch">attachment 275716</a> <a href="attachment.cgi?id=275716&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275716&action=review">https://bugs.webkit.org/attachment.cgi?id=275716&action=review</a>
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1505
> + if ((cond != Signed) && m_fixedWidth)
> + m_assembler.nop();</span >
To me, these 2 lines are not needed.
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1515
> + ASSERT_NOT_REACHED();</span >
Very good idea to add this, but please use "RELEASE_ASSERT_NOT_REACHED" instead.
<span class="quote">> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:1532
> + ASSERT_NOT_REACHED();</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>