[Webkit-unassigned] [Bug 156255] New: Refactor Windows/GTK/EFL usage of addHTTPHeaderField to send an HTTPHeaderName instead of a String

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 5 15:24:06 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156255

            Bug ID: 156255
           Summary: Refactor Windows/GTK/EFL usage of addHTTPHeaderField
                    to send an HTTPHeaderName instead of a String
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wilander at apple.com
                CC: bugs-noreply at webkitgtk.org

During the https://bugs.webkit.org/show_bug.cgi?id=155602 it was noted that Windows, GTK, and EFL call ResourceResponseBase::addHTTPHeaderField() with a String reference as the header name. We should refactor these pieces to instead use HTTPHeaderName::findHTTPHeaderName() and send a HTTPHeaderName enum value to esourceResponseBase::addHTTPHeaderField(). Thus, unknown header names can be handled where error handling makes more sense.

The same goes for ResourceRequestBase::addHTTPHeaderField().

After this refactoring it should be possible to remove the addHTTPHeaderField() functions that receive HTTP header names as strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160405/35fc355c/attachment-0001.html>


More information about the webkit-unassigned mailing list