<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor Windows/GTK/EFL usage of addHTTPHeaderField to send an HTTPHeaderName instead of a String"
href="https://bugs.webkit.org/show_bug.cgi?id=156255">156255</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Refactor Windows/GTK/EFL usage of addHTTPHeaderField to send an HTTPHeaderName instead of a String
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebKit Gtk
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>wilander@apple.com
</td>
</tr>
<tr>
<th>CC</th>
<td>bugs-noreply@webkitgtk.org
</td>
</tr></table>
<p>
<div>
<pre>During the <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor WebSockets handshake to use StringView instead of String for header validation"
href="show_bug.cgi?id=155602">https://bugs.webkit.org/show_bug.cgi?id=155602</a> it was noted that Windows, GTK, and EFL call ResourceResponseBase::addHTTPHeaderField() with a String reference as the header name. We should refactor these pieces to instead use HTTPHeaderName::findHTTPHeaderName() and send a HTTPHeaderName enum value to esourceResponseBase::addHTTPHeaderField(). Thus, unknown header names can be handled where error handling makes more sense.
The same goes for ResourceRequestBase::addHTTPHeaderField().
After this refactoring it should be possible to remove the addHTTPHeaderField() functions that receive HTTP header names as strings.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>