[Webkit-unassigned] [Bug 156098] Replace all RenderTheme::popupInternalPadding methods with a single one returning a LengthBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156098

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 275375 [details]
> Try to fix mac builds
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=275375&action=review
> 
> > Source/WebCore/rendering/RenderTheme.h:187
> > +    virtual LengthBox popupInternalPaddingBox(const RenderStyle&) const { return LengthBox(0); }
> 
> Not sure this function needs the word “Box” in its name. 

I thought about it and decided to leave the Box for consistency with RenderStyle::setPaddingBox and because it returns a LengthBox.

> Also could write:
> 
>     return { 0 };
> 
> Instead of return LengthBox(0);

GCC doesn't like that:

error: converting to 'WebCore::LengthBox' from initializer list would use explicit constructor 'WebCore::LengthBox::LengthBox(int)'

I think it's because there are two explicit constructors receiving an integer, using { 0, 0, 0, 0 } works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160403/83259013/attachment.html>