<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Replace all RenderTheme::popupInternalPadding methods with a single one returning a LengthBox"
href="https://bugs.webkit.org/show_bug.cgi?id=156098#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Replace all RenderTheme::popupInternalPadding methods with a single one returning a LengthBox"
href="https://bugs.webkit.org/show_bug.cgi?id=156098">bug 156098</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=156098#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=275375&action=diff" name="attach_275375" title="Try to fix mac builds">attachment 275375</a> <a href="attachment.cgi?id=275375&action=edit" title="Try to fix mac builds">[details]</a></span>
> Try to fix mac builds
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=275375&action=review">https://bugs.webkit.org/attachment.cgi?id=275375&action=review</a>
>
> > Source/WebCore/rendering/RenderTheme.h:187
> > + virtual LengthBox popupInternalPaddingBox(const RenderStyle&) const { return LengthBox(0); }
>
> Not sure this function needs the word “Box” in its name. </span >
I thought about it and decided to leave the Box for consistency with RenderStyle::setPaddingBox and because it returns a LengthBox.
<span class="quote">> Also could write:
>
> return { 0 };
>
> Instead of return LengthBox(0);</span >
GCC doesn't like that:
error: converting to 'WebCore::LengthBox' from initializer list would use explicit constructor 'WebCore::LengthBox::LengthBox(int)'
I think it's because there are two explicit constructors receiving an integer, using { 0, 0, 0, 0 } works.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>