[Webkit-unassigned] [Bug 156133] New: DumpRenderTree, WebKitTestRunner should be more strict about waitUntilDone()/notifyDone()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156133

            Bug ID: 156133
           Summary: DumpRenderTree, WebKitTestRunner should be more strict
                    about waitUntilDone()/notifyDone()
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: ap at webkit.org, joepeck at webkit.org,
                    lforschler at apple.com, simon.fraser at apple.com
        Depends on: 149319

The fix for Bug 149319 (r198963) included a broken test that only called notifyDone(), but never called waitUntilDone():

Bug 149319: Backdrop Filter should repaint when changed via script
<https://bugs.webkit.org/show_bug.cgi?id=149319>
<http://trac.webkit.org/changeset/198963>

It was fixed in r198971:  <http://trac.webkit.org/changeset/198971>

However, this got me to thinking about whether we could detect such a bad test before it lands by being stricter (meaning crash DumpRenderTree or WebKitTestRunner with an RELEASE_ASSERT) about two conditions:

1. Calling notifyDone() before calling waitUntilDone().
2. Calling waitUntilDone() after calling notifyDone().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160402/7b0b56c0/attachment-0001.html>