<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - DumpRenderTree, WebKitTestRunner should be more strict about waitUntilDone()/notifyDone()"
href="https://bugs.webkit.org/show_bug.cgi?id=156133">156133</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>DumpRenderTree, WebKitTestRunner should be more strict about waitUntilDone()/notifyDone()
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>ddkilzer@webkit.org
</td>
</tr>
<tr>
<th>CC</th>
<td>ap@webkit.org, joepeck@webkit.org, lforschler@apple.com, simon.fraser@apple.com
</td>
</tr>
<tr>
<th>Depends on</th>
<td>149319
</td>
</tr></table>
<p>
<div>
<pre>The fix for <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Backdrop Filter should repaint when changed via script"
href="show_bug.cgi?id=149319">Bug 149319</a> (r198963) included a broken test that only called notifyDone(), but never called waitUntilDone():
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Backdrop Filter should repaint when changed via script"
href="show_bug.cgi?id=149319">Bug 149319</a>: Backdrop Filter should repaint when changed via script
<<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Backdrop Filter should repaint when changed via script"
href="show_bug.cgi?id=149319">https://bugs.webkit.org/show_bug.cgi?id=149319</a>>
<<a href="http://trac.webkit.org/changeset/198963">http://trac.webkit.org/changeset/198963</a>>
It was fixed in r198971: <<a href="http://trac.webkit.org/changeset/198971">http://trac.webkit.org/changeset/198971</a>>
However, this got me to thinking about whether we could detect such a bad test before it lands by being stricter (meaning crash DumpRenderTree or WebKitTestRunner with an RELEASE_ASSERT) about two conditions:
1. Calling notifyDone() before calling waitUntilDone().
2. Calling waitUntilDone() after calling notifyDone().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>