[Webkit-unassigned] [Bug 156089] Add some logic to decide when a video can control the videoControlsManager

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 13:07:59 PDT 2016


--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 275421
  --> https://bugs.webkit.org/attachment.cgi?id=275421

View in context: https://bugs.webkit.org/attachment.cgi?id=275421&action=review

This looks good to me modulo the minor nits noted, but I am not a WK2 reviewer so someone else will have to give the official nod.

> Source/WebCore/html/HTMLMediaElement.cpp:4847
> +        if (endedPlayback() && document().page() && is<HTMLVideoElement>(*this))

As we discussed, this will cause issues when a video's src is changed in the 'ended' event to make a playlist. Probably worth filing a bug to investigate this.

> Source/WebCore/html/MediaElementSession.cpp:219
> +    // FIXME: Audio elements should be able to have a controls manager as well. Audio elements
> +    // should probably only have a controls manager if they started playing via a user gesture.

It would be good to have a bug number here.

> Source/WebCore/html/MediaElementSession.cpp:233
> +    if (renderer->clientWidth() >= elementMainContentMinimumWidth && renderer->clientHeight() >= elementMainContentMinimumHeight) {
> +        if (element.hasAudio() && element.hasVideo())
> +            return true;
> +    }

Do you care if the <video> is visible in the page or not?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160401/2e23004e/attachment.html>

More information about the webkit-unassigned mailing list