<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add some logic to decide when a video can control the videoControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=156089#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add some logic to decide when a video can control the videoControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=156089">bug 156089</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=275421&action=diff" name="attach_275421" title="Patch">attachment 275421</a> <a href="attachment.cgi?id=275421&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=275421&action=review">https://bugs.webkit.org/attachment.cgi?id=275421&action=review</a>
This looks good to me modulo the minor nits noted, but I am not a WK2 reviewer so someone else will have to give the official nod.
<span class="quote">> Source/WebCore/html/HTMLMediaElement.cpp:4847
> + if (endedPlayback() && document().page() && is<HTMLVideoElement>(*this))</span >
As we discussed, this will cause issues when a video's src is changed in the 'ended' event to make a playlist. Probably worth filing a bug to investigate this.
<span class="quote">> Source/WebCore/html/MediaElementSession.cpp:219
> + // FIXME: Audio elements should be able to have a controls manager as well. Audio elements
> + // should probably only have a controls manager if they started playing via a user gesture.</span >
It would be good to have a bug number here.
<span class="quote">> Source/WebCore/html/MediaElementSession.cpp:233
> + if (renderer->clientWidth() >= elementMainContentMinimumWidth && renderer->clientHeight() >= elementMainContentMinimumHeight) {
> + if (element.hasAudio() && element.hasVideo())
> + return true;
> + }</span >
Do you care if the <video> is visible in the page or not?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>