[Webkit-unassigned] [Bug 155927] [TexMap] Trim redundant guards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155927

--- Comment #4 from Emanuele Aina <emanuele.aina at collabora.com> ---
Comment on attachment 274993
  --> https://bugs.webkit.org/attachment.cgi?id=274993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274993&action=review

>> Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:-114
>> -#elif USE(TEXTURE_MAPPER) && !USE(COORDINATED_GRAPHICS_THREADED)
> 
> It seems to me that TEXTIRE_MAPPER is always on, but COORDINATED_GRAPHICS_THREADED is able to be enabled only when ENABLE_OPENGL is on. So I wonder if this !USE(COORDINATED_GRAPHICS_THREADED) guard can be removed.

Indeed it seem there's no relation in the buildsystem between those two variable.

That said, CoordinatedGraphicsState.h uses TextureMapperPlatformLayerProxy if COORDINATED_GRAPHICS_THREADED is enabled without checking for TEXTURE_MAPPER, which seems to support my assumption that COORDINATED_GRAPHICS_THREADED implies TEXTURE_MAPPER.

Now that I'm looking at CoordinatedGraphicsScene.cpp it seems that COORDINATED_GRAPHICS even unconditionally depends on TEXTURE_MAPPER_GL as the TextureMapperGL type is used unguarded...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160401/b8d75a1d/attachment.html>