<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [TexMap] Trim redundant guards"
href="https://bugs.webkit.org/show_bug.cgi?id=155927#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [TexMap] Trim redundant guards"
href="https://bugs.webkit.org/show_bug.cgi?id=155927">bug 155927</a>
from <span class="vcard"><a class="email" href="mailto:emanuele.aina@collabora.com" title="Emanuele Aina <emanuele.aina@collabora.com>"> <span class="fn">Emanuele Aina</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=274993&action=diff" name="attach_274993" title="Patch">attachment 274993</a> <a href="attachment.cgi?id=274993&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=274993&action=review">https://bugs.webkit.org/attachment.cgi?id=274993&action=review</a>
<span class="quote">>> Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:-114
>> -#elif USE(TEXTURE_MAPPER) && !USE(COORDINATED_GRAPHICS_THREADED)
>
> It seems to me that TEXTIRE_MAPPER is always on, but COORDINATED_GRAPHICS_THREADED is able to be enabled only when ENABLE_OPENGL is on. So I wonder if this !USE(COORDINATED_GRAPHICS_THREADED) guard can be removed.</span >
Indeed it seem there's no relation in the buildsystem between those two variable.
That said, CoordinatedGraphicsState.h uses TextureMapperPlatformLayerProxy if COORDINATED_GRAPHICS_THREADED is enabled without checking for TEXTURE_MAPPER, which seems to support my assumption that COORDINATED_GRAPHICS_THREADED implies TEXTURE_MAPPER.
Now that I'm looking at CoordinatedGraphicsScene.cpp it seems that COORDINATED_GRAPHICS even unconditionally depends on TEXTURE_MAPPER_GL as the TextureMapperGL type is used unguarded...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>