[Webkit-unassigned] [Bug 108507] printing does not use minimum page zoom factor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108507

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #10)
> This broke "run-webkit-tests --pixel" behavior, at least on Mac. How it is
> supposed to work is that --pixel has no effect on tests that call
> testRunner.dumpAsText() or testRunner.dumpAsText(false). But now,
> WebKitTestRunner dumps pixels for these, so all text-only tests fail when
> run in this mode.
> 
> This breaks an important testing scenario, so I'll roll out for now.

Oh, I'm sorry about this, I got confused with all the shouldDumpPixels in TestInvocation, TestRunner, InjectedBundle and InjectedBundlePage. Now that I understand it, I'm going to split the patch, first to avoid creating snapshots in the web process that will be ignored, and then the one to fix the printing snapshots.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150928/99ed3a69/attachment.html>